Add containerSecurityContexts to all initContainers #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
hikhvar
force-pushed
the
container-contexts
branch
from
8181634
to
69210ff
Compare
hikhvar
force-pushed
the
container-contexts
branch
from
69210ff
to
d9f0d2a
Compare
robholland
requested changes
Sep 25, 2024
| @@ -53,6 +65,10 @@ spec: | |||
| volumeMounts: | |||
| {{- toYaml . | nindent 12 }} | |||
| {{- end }} | |||
| {{- with $.Values.schema.containerSecurityContext }} | |||
There was a problem hiding this comment.
Please increase the indent a step as per the block above.
|
Closing due to inactivity. Please re-open and make the requested changes if you'd like to continue working on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added containerSecurityContexts to all initContainers in server-job.
Why?
Our internal platform enforces strict security contexts. Without this patch, we are unable to run the jobs.
Checklist
Closes
How was this tested: